Repository navigation
Fix tag release action, add unit tests for PRs and CodeQL - #164
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
@dahlbyk Not sure if you could have a once over? |
dahlbyk
left a comment
dahlbyk
left a comment
There was a problem hiding this comment.
LGTM
As I've mentioned, feel free to give me Write permissions so my review counts. 😁
I don't think we're in a particular hurry. I'm a fan of feedback before PRs land in
Same. |
4 participants
This should help build the release by switching to
windows-latestwhich has the .NET frameworks preinstalled.I've added unit test runs for PRs onto the main branch. This should run in parallel and test against the different frameworks.
| The tests run on parallel with a windows & linux vm, would it be simpler to run on a PR just the linux then before a release do a whole multi framework test?
CodeQL also runs on PR to main branch & on any commit to main branch.
| Not convinced running this EVERY PR & then again when its merged in but open to comments